emberjs / rfcs

RFCs for changes to Ember
https://rfcs.emberjs.com/
790 stars 406 forks source link

Deprecate app-prefix et al #1029

Closed ef4 closed 3 months ago

ef4 commented 6 months ago

Propose "Deprecate app-prefix, app-suffix, tests-prefix, and tests-suffix"

Rendered

Summary

This pull request is proposing a new RFC.

To succeed, it will need to pass into the Exploring Stage), followed by the Accepted Stage.

A Proposed or Exploring RFC may also move to the Closed Stage if it is withdrawn by the author or if it is rejected by the Ember team. This requires an "FCP to Close" period.

An FCP is required before merging this PR to advance to Accepted.

Upon merging this PR, automation will open a draft PR for this RFC to move to the Ready for Released Stage.

Exploring Stage Description This stage is entered when the Ember team believes the concept described in the RFC should be pursued, but the RFC may still need some more work, discussion, answers to open questions, and/or a champion before it can move to the next stage. An RFC is moved into Exploring with consensus of the relevant teams. The relevant team expects to spend time helping to refine the proposal. The RFC remains a PR and will have an `Exploring` label applied. An Exploring RFC that is successfully completed can move to [Accepted](https://github.com/emberjs/rfcs#accepted) with an FCP is required as in the existing process. It may also be moved to [Closed](https://github.com/emberjs/rfcs#closed) with an FCP.
Accepted Stage Description To move into the "accepted stage" the RFC must have complete prose and have successfully passed through an "FCP to Accept" period in which the community has weighed in and consensus has been achieved on the direction. The relevant teams believe that the proposal is well-specified and ready for implementation. The RFC has a champion within one of the relevant teams. If there are unanswered questions, we have outlined them and expect that they will be answered before [Ready for Release](https://github.com/emberjs/rfcs#ready-for-release). When the RFC is accepted, the PR will be merged, and automation will open a new PR to move the RFC to the [Ready for Release](https://github.com/emberjs/rfcs#ready-for-release) stage. That PR should be used to track implementation progress and gain consensus to move to the next stage.

Checklist to move to Exploring

Checklist to move to Accepted

simonihmig commented 3 months ago

What version of Ember (CLI) is this deprecation targeting for removal? I assume v7, because the time window for v6 has already passed by, right?

Although, while it would probably violate some deprecation policies we have in place, I personally wouldn't mind dropping this for v6, given so few addons make use of this, and they seem to be abandonware so none of these will ever be used in any recent Ember!? 🤷