search

embrace-io / embrace-apple-sdk

Embrace's Swift SDK built on OpenTelemetry
https://embrace.io/docs/ios/
Apache License 2.0
117 stars 11 forks source link

Add signal block list to embrace crash reporter #119

Closed ArielDemarco closed 3 weeks ago

ArielDemarco commented 3 weeks ago

Overview

This PR allows configuring the EmbraceCrashReporter through the init method to receive a list of signals that are not to be reported. The signals that can be dropped are those listed in EmbraceCrashReporter.CrashSignal.

[!IMPORTANT]
By default, the EmbraceCrashReporter constructor will not report SIGTERM. If you want to change this behavior, you must pass an empty array (or an array with the signals you don't want to report) to the signalsBlockList parameter in the init method.

github-actions[bot] commented 3 weeks ago

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

github-actions[bot] commented 3 weeks ago
Warnings
:warning: No CHANGELOG entry added.

Generated by :no_entry_sign: Danger Swift against 9675e17f08bd407026c62e926858dcc146d909d9

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 93.60465% with 11 lines in your changes missing coverage. Please review.

Project coverage is 91.93%. Comparing base (b2da5ac) to head (9675e17). Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
Sources/EmbraceCrash/EmbraceCrashReporter.swift 84.84% 10 Missing :warning:
.../EmbraceCrashTests/EmbraceCrashReporterTests.swift 99.05% 1 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/embrace-io/embrace-apple-sdk/pull/119/graphs/tree.svg?width=650&height=150&src=pr&token=R3KMG2Ar52&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io)](https://app.codecov.io/gh/embrace-io/embrace-apple-sdk/pull/119?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io) ```diff @@ Coverage Diff @@ ## main #119 +/- ## ========================================== - Coverage 91.95% 91.93% -0.03% ========================================== Files 408 410 +2 Lines 26457 26582 +125 ========================================== + Hits 24329 24438 +109 - Misses 2128 2144 +16 ``` | [Files with missing lines](https://app.codecov.io/gh/embrace-io/embrace-apple-sdk/pull/119?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io) | Coverage Δ | | |---|---|---| | [.../EmbraceCrashTests/EmbraceCrashReporterTests.swift](https://app.codecov.io/gh/embrace-io/embrace-apple-sdk/pull/119?src=pr&el=tree&filepath=Tests%2FEmbraceCrashTests%2FEmbraceCrashReporterTests.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io#diff-VGVzdHMvRW1icmFjZUNyYXNoVGVzdHMvRW1icmFjZUNyYXNoUmVwb3J0ZXJUZXN0cy5zd2lmdA==) | `99.52% <99.05%> (-0.48%)` | :arrow_down: | | [Sources/EmbraceCrash/EmbraceCrashReporter.swift](https://app.codecov.io/gh/embrace-io/embrace-apple-sdk/pull/119?src=pr&el=tree&filepath=Sources%2FEmbraceCrash%2FEmbraceCrashReporter.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io#diff-U291cmNlcy9FbWJyYWNlQ3Jhc2gvRW1icmFjZUNyYXNoUmVwb3J0ZXIuc3dpZnQ=) | `87.11% <84.84%> (+2.22%)` | :arrow_up: | ... and [7 files with indirect coverage changes](https://app.codecov.io/gh/embrace-io/embrace-apple-sdk/pull/119/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=embrace-io)