Expose Embrace client's metadata to ObjC

embrace-io / embrace-apple-sdk

Embrace's Swift SDK built on OpenTelemetry

https://embrace.io/docs/ios/

Apache License 2.0

117 stars 11 forks source link

Expose Embrace client's metadata to ObjC #85

Closed Germantv closed 1 month ago

Germantv commented 1 month ago

Description

MetadataHandler is defined as an ObjC class but not exposed to ObjC - Adding @objc to metadata prop in Embrace client to use in ObjC.

Checklist

[x] PR Description to summarize changes
[x] Add sufficient test coverage - Not sure if this is applicable as I just added one tiny change to prop
[x] Read Contributing Guidelines
[x] Agree to Embrace CLA

ArielDemarco commented 1 month ago

The "Run Swift Tests" action failed, but not because any tests in the suite failed; it was due to an internal issue (which I address in this PR). Therefore, I see no issue with merging since the real check is that none of the tests are broken. Again, thank you for your contribution @Germantv!

Germantv commented 1 month ago

The "Run Swift Tests" action failed, but not because any tests in the suite failed; it was due to an internal issue (which I address in this PR). Therefore, I see no issue with merging since the real check is that none of the tests are broken. Again, thank you for your contribution @Germantv!

Super excited to be able to contribute! Love your guys' work!! 😄

Germantv commented 1 month ago

Quick question @ArielDemarco - When will this go out into a release?