search

embulk / embulk-output-jdbc

MySQL, PostgreSQL, Redshift and generic JDBC output plugins for Embulk
Other
88 stars 86 forks source link

Use execute() instead of executeUpdate() for afterLoad/beforeLoad #313

Closed hiroyuki-sato closed 11 months ago

hiroyuki-sato commented 1 year ago

Fixing #312

I added test code to embulk-output-postgresql in #319.

@dmikurube and @hito4t Could you check when you get a chance?

Ref: https://embulk-dev.zulipchat.com/#narrow/stream/352993-embulk/topic/output-postgresql.20.3A.20support.20select.20in.20the.20after_load/near/345032157

hiroyuki-sato commented 1 year ago

@dmikurube Thank you for your comment! I'll change the code.

dmikurube commented 11 months ago

@hiroyuki-sato Once you address the comment, I'll include it in the next v0.10.3.

hiroyuki-sato commented 11 months ago

@dmikurube Thanks. I'll fix as far as possible.

dmikurube commented 11 months ago

Okay, I tagged the v0.10.3 milestone on this pull request.

dmikurube commented 11 months ago

I think I'll release v0.10.3 next Tuesday. I'll include it if it's ready by then.

hiroyuki-sato commented 11 months ago

@dmikurube Could you check when you have time?

naka-sho commented 11 months ago

Thanks! Next time I will fix it myself and send a pull request.