search

emeneo / moodle-local_course_templates

With this moodle plugin you can easily create courses based on course templates. The plugin also can be used to easily duplicate courses.
11 stars 11 forks source link

Moodle 3.8 #23

Closed frumbert closed 2 years ago

frumbert commented 2 years ago

According to the page https://moodle.org/plugins/local_course_templates the plugin supports 3.7 and 3.8; however, it relies on the function _require_allcapabilities(...) which was not implemented into accesslib.php until 3.9. Not hard to patch back in, but out of the box it doesn't work < 3.9

Flottertotte commented 2 years ago

Thank you @frumbert , I have already changed the min. version requirement to 3.9 and reopened the older version. In there is someone who is running moodle 3.7. and cannot upgrade and installated the new plugin version that does not run on 3.7. might fix version number so that they can downgrade back. Hope there aren't such cases thanks to your fast warning!

Best, Flotter

andrewscaya commented 2 years ago

@Flottertotte

Would like for us to have a look, and backport the latest changes to Moodle 3.7 and 3.8?

Flottertotte commented 2 years ago

Hi @andrewscaya, that would be awesome, of course. I would then pack new version based on that work and publish update the old package on moodle.org

Flottertotte commented 2 years ago

@andrewscaya I have created a 3.7 branch.

andrewscaya commented 2 years ago

Hi @Flottertotte --

OK. I'll have the PR ready before the end of the day. 👍

andrewscaya commented 2 years ago

@Flottertotte

I have a question for you: do you prefer maintaining two separate branches, or do you want me to simply add a shim in the master branch that will make the main release compatible with 3.X?

Flottertotte commented 2 years ago

@andrewscaya If feel it is easier to handle with 2 separate branches.

andrewscaya commented 2 years ago

@Flottertotte --

Since the 3.7 branch was not available in the public repository, I issued the PR #24 against the master branch. Thus, you can still choose to either have one single version that is compatible (fully tested) with Moodle 3.6+/PHP 7.1+ (simply merge on master), or create a separate branch with this added code/shim (another branch).

If you decide to create a separate branch for 3.6+, I would recommend that you update the main version.php file on the master branch to require Moodle 3.9+ (2020061500).

If you have any questions or comments, please let me know, ok?

TTYL! :)

Yours,

Andrew

Flottertotte commented 2 years ago

@andrewscaya Thank you! I will look into it asap and follow up.

Flottertotte commented 2 years ago

@andrewscaya Thanks again! I just merged to master and published a new release to moodle.org Best, Flotter