Don't show incorrect hatchery URL on Apps screen

emfcamp / TiDAL-badge-webserial

A web interface for badge.team-firmware badges using WebSerial

Other

3 stars 2 forks source link

Don't show incorrect hatchery URL on Apps screen #13

Closed davea closed 2 years ago

davea commented 2 years ago

For some reason repo_name only gets set to tidal the first time the Apps component is shown and is '' subsequently. As a result the generic badge config is chosen and the user ends up seeing a misleading "Apps uploaded to hatchery.badge.team will automatically show up here for everyone." message.

I don't know Vue well enough to fix this properly so figured defaulting to tidal config would be OK for the duration of the event :)

tomsci commented 2 years ago

I don't know this code either, @dpslwk do you have any comment?

davea commented 2 years ago

Actually, it looks like https://github.com/emfcamp/TiDAL-badge-webserial/pull/12/commits/fb3a98c562bd724c5cba15662c0203352f202410 in #12 might fix this in a slightly more sensible way.