search

emilianotisato / nova-google-autocomplete-field

Address Autocomplete with Google Place API (full metadata available)
20 stars 17 forks source link

Cannot search by establishment #6

Closed sotrustmtg closed 5 years ago

sotrustmtg commented 5 years ago

I am trying to search by business name and I cannot get this to pull results. Typing out business names return no addresses (blank). Any idea what I need to do? I have tried the following: GoogleAutocomplete::make('Address') ->placeType('establishment') ->withValues(['latitude', 'longitude','formatted_address','name']) ->hideFromIndex() ->nullable(),

emilianotisato commented 5 years ago

@sotrustmtg

1) Do you see some error in the javascript console? 2) Did it work before without the placeType() specification, and now that you add it does not work? (I ask this to be sure you install it correctly and create your API keys, etc)

sotrustmtg commented 5 years ago

No error. I can type out an address and it auto returns that, just not type out a business name.

[https://esr-storage.s3.amazonaws.com/images/7525/76981/default/images/183875a78b57b0ace8.png?override=1517860310]

John Hamman

•

Manager of Digital Marketing

757-518-0700 ext. 55809

JHamman@SouthernTrust.commailto:JHamman@SouthernTrust.com

4433 Corporation Lane | Suite 300 | Virginia Beach, VA 23462 www.SouthernTrust.comhttps://www.southerntrust.com/

[cid:image002.png@01D50587.DB057730]https://www.facebook.com/SouthernTrustMortgage

[cid:image003.png@01D50587.DB057730]https://www.linkedin.com/company/southern-trust-mortgage/

[cid:image004.png@01D50587.DB057730]https://twitter.com/Southern_Trust

[cid:image005.png@01D50587.DB057730]https://www.instagram.com/southerntrust/

[https://esr-storage.s3.amazonaws.com/images/7525/76981/images/5af314cab3cf1.png]https://marketingrequest.southerntrust.com/

Confidentiality Notice The information contained in this email is confidential and/or legally privileged. If you have received this email in error, please notify us immediately by reply email and then delete this message from your system. If you are not the intended recipient, you are hereby notified that any review, dissemination or copying of this email and its attachments, if any, or of the information contained herein, is strictly prohibited. Thank you

From: Emiliano Tisato notifications@github.com Reply-To: emilianotisato/nova-google-autocomplete-field reply@reply.github.com Date: Wednesday, May 8, 2019 at 10:21 AM To: emilianotisato/nova-google-autocomplete-field nova-google-autocomplete-field@noreply.github.com Cc: "John E. Hamman" jhamman@southerntrust.com, Mention mention@noreply.github.com Subject: Re: [emilianotisato/nova-google-autocomplete-field] Cannot search by establishment (#6)

@sotrustmtghttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_sotrustmtg&d=DwMCaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=k3KMRHEkXM0qyvw4I1DhL7wvNei91P2jPn8ztLpAvik&m=Be7Tq8HXvLvz6vIrD9u_nBUQR3VdrQjnZ-K-NlYusAE&s=Jws3lxOiocpJOhcENa99PCLiKflDzh0lR5DkXdAwQlw&e=

  1. Do you see some error in the javascript console?
  2. Did it work before without the placeType() specification, and now that you add it does not work? (I ask this to be sure you install it correctly and create your API keys, etc)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_emilianotisato_nova-2Dgoogle-2Dautocomplete-2Dfield_issues_6-23issuecomment-2D490505128&d=DwMCaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=k3KMRHEkXM0qyvw4I1DhL7wvNei91P2jPn8ztLpAvik&m=Be7Tq8HXvLvz6vIrD9u_nBUQR3VdrQjnZ-K-NlYusAE&s=ELY2TNujN4vNNNrjsFzJONGZK4TEsX59j7ZTfkxL1A0&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_ALKBLQL7FE4MGOLVMINUCJDPULOTTANCNFSM4HLR3IDQ&d=DwMCaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=k3KMRHEkXM0qyvw4I1DhL7wvNei91P2jPn8ztLpAvik&m=Be7Tq8HXvLvz6vIrD9u_nBUQR3VdrQjnZ-K-NlYusAE&s=kPKMUxxQ2HnuS3Mll8QuMzd7iKqLuTXxb5MK8ps2YlQ&e=.

This email has been scanned for spam and viruses by Proofpoint Essentials. Click herehttps://us4.proofpointessentials.com/index01.php?mod_id=11&mod_option=logitem&mail_id=1557325243-0rsn95WgaVUU&r_address=jhamman%40southerntrust.com&report=1 to report this email as spam.

Southern Trust Mortgage, L.L.C. NMLS #2921 (http://www.nmlsconsumeraccess.org) lends in the following states: District of Columbia - Mortgage Dual Authority License #MLB-2921 | Delaware – Registered Lender | Maryland – Registered Lender | North Carolina – Registered Lender | Ohio – Registered Lender | Pennsylvania – Registered Lender | South Carolina – Mortgage Lender License #MLB-2921 | Tennessee – Registered Lender | West Virginia – Mortgage Lender License #ML-34191 | Virginia – Registered Lender

Southern Trust Mortgage, L.L.C. DBA Southern Residential Lending, L.L.C. lends in the following states: Alabama – Consumer Credit License #22560 | Georgia – Mortgage Lender License #16579 | Florida – Registered Lender | New Jersey – Residential Mortgage Lender License # NA [Equal Housing Lender Icon]

nickpoulos commented 5 years ago

Interesting, I am also seeing this behavior now. No matter what I seem to pass in as 'placeType' I cannot get business results to return anymore. But as far as I rememeber this feature was absolutely working very recently.

I will be exploring this more in depth now, but I am going to check two things:

One, if the additional PR allowing locationResults has broken something, at first glance it doesn't appear so, but we will see. Other possibilities - I am wondering if this tidbit from the docs need to be investigated again: "The exception is that you can safely mix the geocode and establishment types, but note that this will have the same effect as specifying no types."

That is the reason I set the placeType to empty string for my purposes. I wonder if the underlying vue-google-autocomplete has changed somehow.

nickpoulos commented 5 years ago

Latest version is 0.7, so I just downgraded to 0.6, which doesn't have my placeType changes. I re-added the change(s) to add placeType, updated my resource with ->placeType(''), and I am now seeing Business names again.

idragon81 commented 5 years ago

I did some debugging. Found that the nova-google-autocomplete field is setting the type but vue-google-autocomplete is not picking it up. I've fixed it in #8 and updated other references for consistency. Although it's a bit peculiar why this happened

emilianotisato commented 5 years ago

Fixed in #8