Elisp

[MGadhvi]

READ ME BEFORE SUBMITTING A PR

Please do not submit a PR with your solution to the Gilded Rose Kata. This repo is intended to be used as a starting point for the kata.

• [x] I acknowledge that this PR is not a solution to the Gilded Rose Kata, but an improvement to the template.
• [x] I acknowledge that I have read CONTRIBUTING.md

Please provide your PR description below this line

Amended elisp code. Please see latest commit for more details

[codecop]

First review was in #572 . Work in progress

[MGadhvi]

Thank you. Code has been amended. Please see latest commit

[codecop]

Thank you we are moving forward. There is still one thing. Your Gilded Rose update-quality code. Let me try to elaborate. The original code, e.g. https://github.com/emilybache/GildedRose-Refactoring-Kata/blob/main/clojure/src/gilded/core.clj is bad on purpose. We need a port that looks very similar. Your code is something like that

if AgedBrie ...
else if Backstage Pass ...
else if Sulfuras ...
else ...

Also you use min/max. The original code is different:

if not AgedBrie and not BackstagePass ...
if not Sulfuras ...
if not AgedBrie and not BackstagePass ...

And inside it has duplication for the checks >= 0 and <= 50. Further the code needs to check for the exact strings "Backstage passes to a TAFKAL80ETC concert" and "Sulfuras, Hand of Ragnaros"

[MGadhvi]

Thank you. I appreciate the support and guidance

[MGadhvi]

Changes have been made. This has really pushed me to learn elisp better. Please let me know if anything else is needed

[codecop]

Thank you and well done seeing it done.

[MGadhvi]

Thank you and well done seeing it done.

Thank you for your help