If an item CAN have the searched text in the tooltip, it's shown, rather than if it DOES have the text

emilyploszaj / emi

A featureful and accessible item and recipe viewer

MIT License

254 stars 53 forks source link

If an item CAN have the searched text in the tooltip, it's shown, rather than if it DOES have the text #183

Closed aaronhowser1 closed 1 year ago

aaronhowser1 commented 1 year ago

Both of the above searches show every Syringe, which can be set to any LivingEntity. Searching for any LivingEntity's name shows all Syringes.

Searching any potion effect shows every variation of any item that can have that in the tooltip.

emi-1.0.0+1.19.2+forge

emilyploszaj commented 1 year ago

I've been trying to figure out what causes this for a while, and now I believe it may have to do with comparison strictness. This could be resolved for the index using identity comparison, but would mess with the ability to search other sidebars. I believe a compound resolution to this issue would function best:

When doing baked lookup, use strict nbt comparison with cached values
If this fails, recheck the state of the tooltip for the live stack

I'll look into implementing it

emilyploszaj commented 1 year ago

This solution was implemented in 1.0.1