search

emoon / rust_minifb

Cross platfrom window and framebuffer crate for Rust
MIT License
1.01k stars 97 forks source link

Build failure on ARM #216

Closed birkenfeld closed 3 years ago

birkenfeld commented 3 years ago

Compiling for the Raspberry Pi, I get


error[E0308]: mismatched types
   --> /root/.cargo/registry/src/github.com-1285ae84e5963aae/minifb-0.18.0/src/os/posix/x11.rs:423:52
    |
423 |                     (d.lib.XInternAtom)(d.display, "_MOTIF_WM_HINTS\0" as *const _ as *const i8, 0);
    |                                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected `u8`, found `i8`
    |
    = note: expected raw pointer `*const u8`
               found raw pointer `*const i8`

error: aborting due to previous error

Probably best to use c_char?

birkenfeld commented 3 years ago

Also, shouldn't that be a byte literal b"_MOTIF_WM_HINTS\0"?

birkenfeld commented 3 years ago

Ok, I see this has been fixed already in master. New release please? :)

emoon commented 3 years ago

Yeah, I can do a new release today

emoon commented 3 years ago

0.19 has now been released :)

birkenfeld commented 3 years ago

Great, thanks!

emoon commented 3 years ago

np!