empowerai / fs-permit-platform

Module for intake of special use applications for Forest Service Application Permits
Other
3 stars 0 forks source link

As a COR, I want a maintainable application WIKI so that I can meet the FS needs #572

Open lauraGgit opened 6 years ago

lauraGgit commented 6 years ago

Notes

Catchall card for overall code review comments.

In order to make it easier to find where the comments are reference, i'm left them in the order that they are in the code - however, I have now prioritized the comments based on must have for compliance, should probably have and nice to have tasks.

Tasks

Wiki

Review Progress

fs-permit-platform
├── .cg-deploy ✔️
│   └── manifests
│       ├── production
│       ├── staging
│       └── trees-staging
├── .circleci ✔️
├── .github ✔️
├── design-deliverables ✔️ 
│   └── UX
│       └── design_options
├── docker  ✔️ 
├── frontend ✔️
│   ├── e2e  ✔️ 
│   │   ├── authenticated  ✔️ 
│   │   │   ├── christmas-trees  ✔️ 
│   │   │   ├── special-uses  ✔️ 
│   │   │   └── test-files  ✔️ 
│   │   └── unauthenticated  ✔️ 
│   └── src ✔️
│       ├── app ✔️
│       │   ├── _directives  ✔️ 
│       │   ├── _mocks  ✔️ 
│       │   ├── _models  ✔️ 
│       │   ├── _pipes  ✔️ 
│       │   ├── _services  ✔️ 
│       │   ├── _shared  ✔️ 
│       │   ├── api-error  ✔️ 
│       │   ├── application-forms ✔️
│       │   ├── applications ✔️
│       │   ├── breadcrumbs ✔️
│       │   ├── error-pages ✔️
│       │   ├── help-me-pick ✔️
│       │   ├── home ✔️
│       │   ├── login ✔️
│       │   ├── pay-gov-mocks ✔️
│       │   ├── progress ✔️
│       │   ├── sidebar ✔️
│       │   ├── status ✔️
│       │   ├── style-guide ✔️
│       │   ├── trees
│       │   │   ├── _services ✔️
│       │   │   ├── admin ✔️
│       │   │   └── forests ✔️
│       │   └── usa-banner ✔️
│       ├── assets ✔️ 
│       │   ├── config
│       │   ├── content
│       │   ├── css
│       │   ├── favicons
│       │   ├── files
│       │   └── img
│       ├── environments ✔️ 
│       └── sass ✔️ 
│           ├── components ✔️
│           ├── core ✔️
│           ├── elements ✔️
│           └── pages ✔️
├── server
│   ├── dba ✔️
│   │   ├── migrations ✔️
│   │   │   └── modules ✔️
│   │   └── seeders ✔️
│   ├── docs ✔️
│   │   └── api ✔️
│   ├── src ✔️
│   │   ├── auth ✔️
│   │   ├── controllers ✔️
│   │   ├── email ✔️
│   │   │   ├── assets ✔️
│   │   │   └── templates ✔️
│   │   ├── mocks ✔️
│   │   ├── models ✔️
│   │   ├── routers ✔️
│   │   ├── services ✔️
│   │   └── templates ✔️
│   │       └── christmas-trees ✔️
│   ├── test ✔️
│   │   └── data ✔️
│   └── vcap-services ✔️
└── wiki ✔️
    ├── christmas-trees ✔️
    │   ├── content ✔️
    │   ├── process ✔️
    │   ├── scrum-ceremonies ✔️
    │   └── usability-testing
    ├── development
    └── security-report

Definition of Done

sadlerw commented 6 years ago

@lauraGgit I wasn't quite sure what you were after here so I just did what the tasks said - please let me know if there are additional changes needed. Thanks, Will