Open sadlerw opened 6 years ago
@lauraGgit you mention commenting for jsdoc above but we are using typedoc already which will automatically create function entries based on typescript. See http://typedoc.org/guides/doccomments/ We can audit for entries that require additional information other than the defaults, but adding /* / everywhere is not needed afaik.
@lauraGgit For the below item: Need that else to handle forest that don't have areas (also clears previous areas) 2 Don't need an else block here; https://github.com/nciinc/fs-permit-platform/blob/sprint-11-development/frontend/src/app/trees/admin/district-dates/district-dates.component.ts#L83
@lauraGgit For this item: this service is used for the landing (find forest) & guidelines pages. Can be still renamed if you prefer so. 2 sprint-11-development/frontend/src/app/trees/_services/christmas-trees is now more about the guidelines no? would it make sense to rename this service?
Notes
Acceptance criteria
Tasks
Frontend
frontend/replace.build.js
/update-version
could use some documentation on what it does.(will)frontend/development-configurations
directory (will)frontend/e2e/unauthenticated/check-authentication.e2e-spec.ts
is there any way to check redirects back to the application from the service provider? understand if that is not possible. -not possible without disabling mocks and using a static account that would need to be maintained as part of each build (passwords updated etc.) (will)frontend/e2e/authenticated/app.po.ts
into thespecial-uses
directory (will)frontend/src/assets/img/
species files could be their own directory. We may want to break it out further based off of/maps
/side-wide
to better navigate this directory. (shekar)frontend/src/environments
do we need separate change request forms? Seems like we'd likely have the same? or is this on account of local development? https://github.com/nciinc/fs-permit-platform/blob/sprint-11-development/frontend/src/environments/environment.prod.ts#L6 - Currently we have to make an environment file - the environments.ts is just a stub and it is currently a requirement in angular-cli that every property be in every file. That might change in future though as it is seen as a short-coming. (will)Frontend/app
Home
the shared components like header and footer and then change this tospecial-use-landing-page
as the actual home component is much more specific (seth)Login
directory toAuthentication
? or would that result in a naming conflict? (shekar)status
component the centrally used alert component?Status
is a bit of confusing term to me in that regard as it has a specific meaning in the context of special use application approval. (seth)Pipes
ColumnizeArray
is still a Pipe that is being used. Please remove if so.(shekar)filter
pipe is inconsistent with other pipes capitalization.(shekar)LineBreakFormatter
pipe also may no longer be necessary post markdown refactor.(shekar)Services
auth-guard
andauthenication
services to clarify that one is about redirecting and one is aboutauthorization
? or consolidate the two services into a single service for clarity(shekar)Trees
app/trees
(will)assets/content
? https://github.com/nciinc/fs-permit-platform/blob/sprint-11-development/frontend/src/app/trees/_services/christmas-trees.service.ts#L72 (will)sprint-11-development/frontend/src/app/trees/_services/christmas-trees
is now more about the guidelines no? would it make sense to rename this service? (shekar)assets
directory in two places? https://github.com/nciinc/fs-permit-platform/blob/sprint-11-development/frontend/src/app/trees/forests/tree-guidelines/tree-species/tree-species.component.html#L9 - because i know they are also inassets/imgs
(shekar)/assets/content/common/species
and images are inassets/img/species
Definition of Done