empowerhack / DrawMyLife-Service

API and Admin system for the Draw My Life initiative - Volunteers: check README and GitHub Projects to get started.
https://github.com/empowerhack/DrawMyLife-Service/projects
MIT License
13 stars 0 forks source link

Image Editing: Ability to rotate images #88

Open krissy opened 7 years ago

krissy commented 7 years ago

What

Allow the user to rotate images on upload/edit and add interaction buttons

How

Liase with team on Slack re UI

rocioleon commented 7 years ago

The solution is based on the research about Ephox TextBoox.io and Wix.com edit image features. There are attached a wireframe to be reviewed.

ephox_research_

https://www.ephox.com/blog/from-the-ux-desk-road-testing-inline-image-editing/

rocioleon commented 7 years ago

Here is a link to see the TextBox.io documentation in case this is helpful http://docs.ephox.com/display/tbio/Getting+Started

rocioleon commented 7 years ago

After feedback, here is the amended wireframe for desktop. The idea is after having selected the file, the user can click on the thumbnail to open the edit popup module to rotate, and crop(rotate or the image. Then apply changes or cancel to close the popup. in-line_image_editing-1024px 5 in-line_image_editing-1024px_popup 6

rocioleon commented 7 years ago

This is the version for the phone device in-line_image_editing-320px 7

rocioleon commented 7 years ago

Any feedback or question...

marizoldi commented 7 years ago

What if we placed the crop/rotate/ok functions in a small rounded menu that is an overlay onthe image (currently I put it on the right side). The cancel function can be just clicking outside the overlay box. I have made an example below.

I have used Material icons which are free and super helpful for dev too: https://design.google.com/icons

They inlcude this rotate and crop function which I think is useful to add to the menu ..

crop-rotate-01 crop-rotate-02

rocioleon commented 7 years ago

Thanks! Let's talk about it.

CathMollie commented 7 years ago

Both of these ideas are good. We could A/B test them maybe - with our existing piloters in Serbia or with our EH community? @rocioleon what do you think?

tanyapowell commented 7 years ago

@rocioleon for the mobile version, would a user still have to double click on an image to get the image editing options to appear in the overlay? Also, is it worth having a button so there is a clear CTA instead of having a label saying (Double click on image to edit)? So that it's really really obvious that option is available?

krissy commented 7 years ago

@CathMollie @rocioleon @EChesters @tanyapowell @marizoldi Who owns the UX decisions for this ticket and #89? Now we're moving towards HDX dataset integration we need to prioritise the quality of our data, so ability to rotate (then crop secondary) could now become a priority, at least for Super Admins to start for post-editing. Should we resume convo?

CathMollie commented 7 years ago

Cath comments on Slack, 16 March:

rocioleon commented 7 years ago

Working on this week as wireframe needs to be amend + Google Material design suggested by @marizoldi + Upload New Drawing Form design by @EChesters Then, -#89 will be updated accordingly @EChesters