Fastboot Extension Issue

[deanmraz]

Issue:

• When running with fastboot and using custom extension, I get this error below:

Error: Error in myextensionname extension-> sub-extension 0: property "type" must be a string, but undefined given

Notes

• works fine when you run it without fastboot.

Example Project

• https://github.com/deanmraz/ember-showdown
• just run yarn install and ember serve

I will be looking for solution but just wanted to open this issue to see if anyone has already solved it!

[deanmraz]

@gcollazo let me know if you have any thoughts.

[jasonmit]

I'll take a look as soon as I can. Thank you for the example, will speed up the process.

[jasonmit]

@deanmraz just an update, looks like showdown is taking a wrong path: https://github.com/showdownjs/showdown/blob/b5e46fdb8dd72ddc74c532e80410536c0a38523c/src/showdown.js#L195

Showdown is wrapping an array within an array because isArray(ext) === false when it should be true.

This is likely an issue with the use of Fastboot's use of Node's VM API that the Ember app is run within. Speculation... need to dig deeper.

[jasonmit]

https://github.com/nodejs/node/issues/855#issuecomment-74583712 I believe is the root of the problem. The work around for now is do not return an array from within your extension function.

[jasonmit]

https://github.com/showdownjs/showdown/pull/425 is the fix, will need to wait for it to be merged/versioned.

[jasonmit]

Reopening since I have a patch on our end. Minor breaking change so will version as 4.0.0. The breaking change is no longer rely on the showdown global and require it to be imported.

[jasonmit]

Released as 4.0.0

[deanmraz]

@jasonmit confirmed it works in my project, thanks man great work!