search

empress / ember-cli-showdown

Ember component to render markdown into HTML.
https://empress.github.io/ember-cli-showdown/
MIT License
101 stars 35 forks source link

global ENV options don't work for engines #63

Closed mattmarcum closed 6 years ago

mattmarcum commented 6 years ago

When you use showdown inside an engine the global options from the parent app aren't being read out of the config. I think using ember-get-config would fix this problem. The markdown-to-html component just looks up the config for the engine addon, not the parent.

jasonmit commented 6 years ago

@mattmarcum PRs are welcome, I know nothing about engines in order to support this.

jasonmit commented 6 years ago

@mattmarcum can you verify that https://github.com/gcollazo/ember-cli-showdown/pull/64 resolves your issue

jasonmit commented 6 years ago

https://github.com/ember-engines/ember-engines/issues/176 this is an upstream issue and it's unsolved for now.