Mark homework 7 of Emily West

[emwest]

@gvdr, @ksedivyhaley @JoeyBernhardt, Homework 7 is ready for review 👍 https://github.com/emwest/STAT547A/tree/master/hw07

latest commit: https://github.com/emwest/STAT547A/commit/551155e96c3c2cc1b0d511aff436a94d57f01b05

[yidie]

Hi @emwest ,

• Makefile

You used source in Makefile. But I think you should have a real Makefile, which should have all, clean, the intermediate input/output, and call those three .R scripts you wrote to automate the pipeline (gapminder_download.R, gapminder_exploratory.R, and gapminder_statistics.R). The point is that when you click "build", everything will be built automatically. While source needs to be run line by line and it is not the proper make syntax. You might want to go over this tutorial to see what make does and how it works.

• Analysis

It is good that you have three scripts to do downloading, explanatory and statistical analysis. And you have comments along the code to explain what you did, which is easy to follow. And I think you implemented almost all the tasks correctly. And you showed your understanding of dplyr, ggplot, saving files/figures and writing functions. Good job!

Your process report is detailed and I can see your effort. README is informative and organized. It would be perfect if you succeed in creating a proper Makefile. So going over the tutorial above and maybe revisit this homework and create a real Makefile.

Yidie

[dorawyy]

Hi Emily,

I'm glad reviewing your homework! Overall, I think you did a good job.

• You provided well-organized and clear instructions about steps of your analysis, reflections about troubles you met during the homework, and reasons of your implementation decisions;
• You have good coding style: neat code style, clear code structure, helpful comments;
• I personally used shell for this homework, therefore, it's good for me to see how the similar process is automated using pure R script;
• I like your emoji style a lot! Very lovely 😉

Here are suggestions for potential improvements:

• You specified plot_loc and csv_loc, maybe you can do the same thing for .rds files as well as .png files, which would make the project structure clean and neat;
• In _gapminderstatistics.R, you could define a function to reduce code redundancy, rather than running similar code for each continent every time;
• Personally, compared with R script, I am more used to .Rmd, as I can see results of each code chunk immediately in the Rmarkdown report, thus I get a bit lost in the middle when reading the R script, but I think this might be something that I need to work on.

Hope these helps! -Yingying

[ksedivyhaley]

Three or more scripts, an Rmd, and a Makefile: Ok (Makefile is R script) Starts by downloading data, ends with Rmd: Partial (no Rmd) The output of each is the modified input of the previous step: Yes Includes some analysis and at least one figure: Yes Makefile includes all scripts and Rmd with correct dependencies: No (is R Script) Makefile runs: No (see comments) Bonus: No Reflection: Yes

Comments:

• It looks like you have extra files in the main directory duplicated when you started saving files in the png and csv subfolders. It would be nice to clean those up.
• Your assignment should include an Rmd as a summary reporting your results, which you render as part of your Makefile.
• Your Makefile.R uses overly detailed paths. "/Users/Adelaide/Desktop/UBC_Work/STAT545/stat547/hw07/gapminder_download.R" does not exist on my machine, and it might not exist on your machine in a few years. When defining paths, you can assume your working directory is where the Rproj file is located – in this case, use “hw07/gapminder_download.R”.
• Also, I get two errors running gapminder_statistics.R “Error in str(model.1tidy) : object 'model.1tidy' not found” and “Error in is.data.frame(Europe) : object 'Europe' not found.” It looks like you left some testing code in the script and then changed the stuff it was supposed to test. Always good practice to clear your workspace and re-run everything together to make sure the script works.

Your mark will be distributed later. If you would like more feedback, please feel free to message me on slack.