search

enBloc-org / kindly

Open source repository for the development of Kindly
GNU General Public License v3.0
18 stars 21 forks source link

#341: Default profile image in ConversationCard component #345

Closed AnyaVeselova closed 1 month ago

AnyaVeselova commented 2 months ago

Description

Closes #341

This pull request creates a function handleError which sets the imgSrc state to the default placeholder image when the src fails to load. This functionality is handled with the usage of onError event in the next Image component.

Files changed

ConversationCard

UI changes

Screenshot from 2024-09-21 23-08-50

netlify[bot] commented 2 months ago

Deploy request for cool-creponne-3e1272 pending review.

Visit the deploys page to approve it

Name Link
Latest commit b9930a3609b71a3b2e776ec552adefb3e0c1a447
AnyaVeselova commented 2 months ago

How do I do this? 🤔

ShaughnAnderson94 commented 2 months ago

How do I do this? 🤔

hard to know exactly what caused it but the most common thing is that uncommitted changes follow you when you switch branches or you are not going into dev before making the new branch so its based off your current branch which might be a different one

AnyaVeselova commented 2 months ago

Thank you for trying to help with my daily git struggles, @ShaughnAnderson94 ! Is it ok after I force-pushed the branch? I think those ghosts are gone now.

camelPhonso commented 1 month ago

Brilliant stuff! Thanks Anna 🙌

Oh no, I didn't notice there's a conflict in this file 🤦

Can you merge the latest from dev and solve this conflict? We'll merge it in once that's cleared