search

enGits / enGitsDataLib

GNU Lesser General Public License v3.0
0 stars 0 forks source link

edl::real should go (or not)? #4

Open ogloth opened 1 year ago

ogloth commented 1 year ago

edl::real is defined as float or double, depending on how enGitsDataLib was compiled. This is nonsense and should be left to the user of EDL to decide. Basically, compiling a single and double precision version of EDL separately is not a good approach (and not required, due to the template nature of EDL).

ftpronk commented 1 year ago

You could require edl to be used as an in-tree dependency, and have the CMake configuration of your main project define what edl::real should be, and propagate that down to the edl sub-folder. And if you compile it statically, you won't have different versions of enGitsDataLib laying around anymore.