search

encounter / objdiff

A local diffing tool for decompilation projects
Apache License 2.0
99 stars 18 forks source link

Filter Sybmols doesnt work for all sections. #80

Closed SquareMan closed 2 months ago

SquareMan commented 3 months ago

Possibly only works for .text, not sure.

This example file is zEntPlayer from bfbb. If I try to filter for sHackStuckDir from .bss the search fails.

image

image

Filtering for symbols in .text works fine however.

LagoLunatic commented 3 months ago

This bug specifically seems to happen for capital letters. When I just tested (version: v2.0.0-alpha.5), lowercase letters, numbers, and symbols like @ and $ can be filtered on in data sections, but uppercase letters never match the filter regardless of whether you type them in as uppercase or lowercase.

SquareMan commented 3 months ago

Additionally .comm symbols don't filter at all (seen in the screenshot)

LagoLunatic commented 2 months ago

Also, while the capital filtering bug doesn't affect C++ functions, it does seem to affect extern "C" functions. e.g.:

extern "C" {
void Test() {

}
}