search

endroid / qr-code

QR Code Generator
https://endroid.nl
MIT License
4.46k stars 728 forks source link

Installation fails on PHP 7.2 #223

Closed lucc closed 5 years ago

lucc commented 5 years ago

I am useing PHP 7.1 from the ReadHat Software Collection on CentOS 7. When I try to do a fresh install from my composer lock file I get an error from the endroid/installer dependency:

$ rm -rf vendor  # for a fresh install
$ php --version
PHP 7.1.30 (cli) (built: Aug 21 2019 09:27:22) ( NTS )
Copyright (c) 1997-2018 The PHP Group
Zend Engine v3.1.0, Copyright (c) 1998-2018 Zend Technologies
    with Xdebug v2.7.2, Copyright (c) 2002-2019, by Derick Rethans
$ composer --version
Composer version 1.9.0 2019-08-02 20:55:32
$ composer install --no-dev
Loading composer repositories with package information
Installing dependencies from lock file
Package operations: 36 installs, 0 updates, 0 removals
  - Installing endroid/installer (1.1.3): Loading from cache
Plugin installation failed, rolling back
  - Removing endroid/installer (1.1.3)

  [ErrorException]                                                                                                                     
  include(/var/www/html/dev/infoportal/src/data/vendor/endroid/installer/src/Installer.php): failed to open stream: No such file or d  
  irectory                                                                                                                             

install [--prefer-source] [--prefer-dist] [--dry-run] [--dev] [--no-dev] [--no-custom-installers] [--no-autoloader] [--no-scripts] [--no-progress] [--no-suggest] [-v|vv|vvv|--verbose] [-o|--optimize-autoloader] [-a|--classmap-authoritative] [--apcu-autoloader] [--ignore-platform-reqs] [--] [<packages>]...

I noticed that this particular dependency has been removed in a recent release (3.7.1). Sadly I can not use that new release as it requires a newer PHP version (since 3.6.0). Might it be possible to make a bugfix release (say 3.5.9) that also removes the dependency on the installer package but does not requre php 7.2?

composer-files.zip

endroid commented 5 years ago

Hi @lucc I created a release 3.5.9 for you based on 3.5.8 but with the installer dependency removed. Hope that helps.

lucc commented 5 years ago

thank you very much, will test when I am back at work.

lucc commented 5 years ago

It worked nicely :)