endroid / qr-code

QR Code Generator
https://endroid.nl
MIT License
4.46k stars 728 forks source link

EPS writer broken #250

Closed Lozik closed 4 years ago

Lozik commented 4 years ago

The EPS writer seems to be broken. Attached to this issue is a file (the first one) generated with the library and EPS writer (converted to PNG to be able to upload to github & ROTATED by 90°). The second file is also generated with this library but with the SVG writer (again, converted to PNG for github). The SVG writer has the same output as the PNG writer. Some readers will be able to read the first QR code, others will not (especially khanamiryan/qrcode-detector-decoder will not and throw a Checksum Exception). Strangely, the EPS writer output does not have the same error correcting level. I don't know how this is possible, considering the libraries code. No settings, except the writer have been changed between the two generations. I expected the QR codes to be identical.

Side note: it is also strange that the generated QR code is flipped by 90° (but if done correctly, this is not wrong).

broken not-broken-svg

endroid commented 4 years ago

Hi @Lozik thank you. When I create a QR code for the string "test" and save it to different formats, I see you are right: the EPS is generated differently than the PNG and SVG: it contains exactly the same blocks but it is mirrored (upside down) so I think an axis is reversed somewhere. I will look into it.

endroid commented 4 years ago

This should now be fixed in 3.8.1

Lozik commented 4 years ago

Thanks a lot! Works like a charm now.

BillyBrooks commented 2 years ago

How I'm I supposed to scan if it's on this phone