engobi / libjingle

Automatically exported from code.google.com/p/libjingle
0 stars 0 forks source link

peerconnection_client sample crashes when entering a hostname instead of an ip address to connect to #401

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. build peerconnection_client sample from webrtc
2. run it
3. enter a hostname in the server field
4. click connect

What is the expected output? What do you see instead?

I would expect the sample to resolve the given hostname and connect
(everything works fine when using an ip address instead of a hostname). Instead 
the sample crashes.

What version of the product are you using? On what operating system?

Windows 7, libjingle r175 from webrtc.

Please provide any additional information below.

It seems that 
    talk_base::Thread::Current()
is null when 
    if (server_address_.IsUnresolved())
is called, leading to a null pointer dereference (i.e. there is no main thread 
set).

Setting a main thread (e.g. by calling 
talk_base::ThreadManager::Instance()->WrapCurrentThread()) before this block 
"fixes" the issue but seems to block the GUI (so I assume that this is the 
wrong way to solve this).

Original issue reported on code.google.com by philipp....@googlemail.com on 10 Oct 2012 at 11:13

GoogleCodeExporter commented 9 years ago
Apparently fixed as of rev 204.

Original comment by philipp....@googlemail.com on 5 Nov 2012 at 10:12

GoogleCodeExporter commented 9 years ago

Original comment by pthatc...@google.com on 19 Jun 2013 at 7:18