cpovirk
commented
1 month ago Just to restate this for anyone who stumbles across this thread later: As a general rule, there's no slam-dunk choice for which nullness checker to use at this point.
For the particular case of a greenfield project with ~zero(?) Java dependencies and a small (n ≈ 1 :)) number of developers who would need to be educated, I would probably try EISOP if you care about generics and NullAway if you don't.
The most likely source of complications for EISOP would be the "Bazel" part. The EISOP docs link to a Stack Overflow question with no "answer" per se, just "Here's how you'd set up NullAway." I would expect the general approach to transfer to EISOP, but our internal setup at Google is (as you've probably seen) different (mostly (but not exclusively) in ways that make it worse :)), so I haven't actually tried a "normal" Bazel setup. If you're lucky, all you need is to add some deps.
So you might start with NullAway to get at least something set up (since the instructions there are more likely to Just Work), iterate until the nullness errors are gone, and then decide whether to pursue using the stricter EISOP.
(To enable either checker automatically more widely than a single target, you may be able to take advantage of java_package_configuration or exported_plugins.)
vorburger
wmdietl
Many 🌔 ago I kicked off http://www.lastnpe.org.
I have not had the free cycles anymore recently to maintain that, but there are apparently still some folks interested in it; note e.g. @agentgt re. https://github.com/lastnpe/eclipse-null-eea-augments/issues/165 and maybe @sebthom in https://github.com/lastnpe/eclipse-null-eea-augments/issues/166.
My current passion project is this repo, see https://docs.enola.dev. I actually do use https://jspecify.dev annotations here and there in this repo already, and occasionally IntelliJ IDEA will point something out (although it apparently has some limitations).
The "real proper thing to do" here, in an ideal world, with unlimited time in the day, would of course be for the build process of this project (not just IDE UI) to do nullness analysis, and fail CI/CD in case of bugs, etc. Let that be the goal of this issue - perhaps one day.
If I had this here, perhaps I would be more interested (again) in contributing to external annotations for JDK, and perhaps other libraries, such as https://github.com/jspecify/jspecify/issues/25... 🤞🏽
Which of these is easiest to integrate into the (currently) Bazel based build process of this project?
@cushon @cpovirk @netdpb do you perhaps have any guidance among the available options for which Nullness checker to adopt now, for a "greenfield" project such as this one, with a Bazel-based build, and existing
org.jspecifyusage?