enoqueJonas
commented
2 years ago @sajid-munawar https://github.com/sajid-munawar Hello. I can not access the exact values (width, height, padding, etc) on the figma template https://www.figma.com/file/l7SqJ3ZfkAKih9sFxvWSR4/Microverse-Student-Project-1?node-id=39%3A122 I chose. It does not show the form section and its elements as it does on other templates. Can you please help me get the exact values?
Sajid Munawar @.***> escreveu no dia quarta, 28/09/2022 à(s) 00:21:
@.**** requested changes on this pull request. Changes Required Hi @enoqueJonas https://github.com/enoqueJonas
Nice job, you are almost there.
https://camo.githubusercontent.com/34482800e1b92cb79ddca06edb4051edc407cb190f896e1e949e596aa9073851/68747470733a2f2f6d656469612e67697068792e636f6d2f6d656469612f556461535559436c723932636a57706556782f67697068792e676966 (Highlights) Good Points:
- Good commit messages. ✔️
- No linter errors. ✔️
- Followed Github flow ✔️
- Professional README file. ✔️
- PR has a good title and summary ✔️
(Changes Required) Aspects to improve:
- Please check my inline comments.
- I kindly suggest that you add a more descriptive PR title and description.
EXAMPLE
Hello World
In this Pull Request, I:
Created branches with different base branches.
Followed GitHub flow.
Added a descriptive and easy to understand README
Added a HTML file
Added a CSS File
Added a h1 text of "Hello-World"
[Optional] suggestions:
- Nothing to mention.
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding! 👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear Please, remember to tag @sajid-munawar https://github.com/sajid-munawar in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy https://microverse.zendesk.com/hc/en-us/articles/1500004088561 you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form https://airtable.com/shrQAqnBwek5a0O0s.
In index.html https://github.com/enoqueJonas/Portfolio/pull/7#discussion_r981749147:
<input type="email" @.***" name="user_mail" required/>
-
- [ ] [REQUIRED] It would be better to have the name placeholder text be an Name instead of a specific name. Take note of the First letter capitalization. Please implement this.
[REQUIRED] It would be better to have the email placeholder text be an Email address instead of a specific email. Take note of the First letter capitalization. Please implement this.
In index.html https://github.com/enoqueJonas/Portfolio/pull/7#discussion_r981753867:
@@ -278,6 +278,18 @@
Skills
</li> </ul> </section>
Contact me
If you have an application you are interested in developing, a feature that you need built or a project that needs coding. I’d love to help with it
<input type="email" @.***" name="user_mail" required/>
Get in touch
- I suggest you remove span tag from inside button tag. there is no need for that, the button tag can handle the submission.
In css/Style.css https://github.com/enoqueJonas/Portfolio/pull/7#discussion_r981769205:
+#contact {
display: flex;
flex-direction: column;
order: 3;
width: 320px;
height: 779px;
background-image: url("../img/Contact\ me.png");
background-repeat: no-repeat;
align-items: center;
justify-content: center;
+}
- Please stick to the Figma, kindly make sure you followed all the core requirements. take care of padding and margins. check your design https://raw.githack.com/enoqueJonas/Portfolio/update-contact-form-style/index.htmland fix it, please. 👉 figma design https://www.figma.com/file/l7SqJ3ZfkAKih9sFxvWSR4/Microverse-Student-Project-1?node-id=39%3A122
— Reply to this email directly, view it on GitHub https://github.com/enoqueJonas/Portfolio/pull/7#pullrequestreview-1122745058, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASG3SOQIQUFXDGQMFDAJNMDWANXNTANCNFSM6AAAAAAQXFZBGM . You are receiving this because you were mentioned.Message ID: @.***>
Updated: