Codebase best practices check

enoqueJonas / ToDo-List

A web page that allows you to manage your todo list. You can create, delete and mark todos as done, and you can refresh the page and not lose your list. Built with JavaScript.

MIT License

2 stars 0 forks source link

Codebase best practices check #6

Closed enoqueJonas closed 1 year ago

enoqueJonas commented 1 year ago

Checking if my code follows:

DRY
KISS
YAGNI

enoqueJonas commented 1 year ago

DRY

My codebase is not DRY, I found the following issues:

I repeat event.target. a lot , I could just pass event.targe as an argument instead of just passing event.

enoqueJonas commented 1 year ago

KISS & YAGNI

My codebase does not follow all KISS & and YAGNI best practices, I found the following issues:

Instead of using !==true, I could just use ===false.