search

enriquea / feseR

feseR: Combining feature selection methods for analyzing omics data
https://github.com/enriquea/feseR
GNU General Public License v2.0
15 stars 3 forks source link

Pipeline improvements #1

Closed drychkov closed 5 years ago

drychkov commented 5 years ago

Hi Enrique,

First, thanks for the creating this feseR package! I found it very handy and I actually use it (with some modifications) in my research.

So, I made some improvements into the pipeline, like introducing parallel computations, AUC and Kohen's Kappa for benchmarking, and a tolerance parameter. Just wanted to let you know about them, maybe you would like to include these modifications into your official branch. Feel free to do so. You can check them out here: https://github.com/drychkov/feseR

Thanks! Dmitry

ypriverol commented 5 years ago

@drychkov can you create a PR into the main repo, we can review it and merge it.

enriquea commented 5 years ago

Hi @drychkov,

Thanks for using the package and your improvements are welcome. As suggested by @ypriverol, could you please make a PR?

Best, Enrique

drychkov commented 5 years ago

Sure! Just created it.

drychkov commented 5 years ago

Guys, I think you need to fix Readme and description files. The changes I made there are not relevant to you (you need to keep ROCR package to import in the Description file though).

enriquea commented 5 years ago

All improvements are integrated. I've also fixed Readme, Description and the tests!