search

ente-io / ente

Fully open source, End to End Encrypted alternative to Google Photos and Apple Photos
https://ente.io
GNU Affero General Public License v3.0
16.33k stars 847 forks source link

[Bug] Amazon Web Services does not show an icon. #3867

Closed tur1ngb0x closed 3 weeks ago

tur1ngb0x commented 1 month ago

Description

Amazon Web Services entry in the Windows Desktop app does not show an icon.

OS: Windows 10 Build 19045.4894 Client: Ente Auth v4.0.2 Service: Amazon Web Services Issuer: aws.amazon.com Account: aws.amazon.com

Main Page Token Options
1 2

Version

4.0.2

What product are you using?

Ente Auth

What platform are you using?

Desktop - Windows

LeGenDaRy15PT commented 1 month ago

Hello @tur1ngb0x

It will probably be added in the next update, I added this icon last week. AWS icon

KingLuc12 commented 1 month ago

The issue is the "Account Issuer" isn't "Amazon Web Services". aws.amazon.com has not been added as one of the "altNames".

If you set the issuer name to Amazon Web Services, then the icon should appear. I recommend someone adds "aws.amazon.com" in the list of "altNames" so that by default people will have the logo - Well at least it should work if someone did that but, altNames are currently not working as I mentioned here: #3875

TLDR: Change the issuer name to "Amazon Web Services" and it should work as expected.

LeGenDaRy15PT commented 1 month ago

I actually made a python script to send the name of the images.svg to a notepad and then through that notepad I had each image name per line and as I put in several icons I configured them alphabetically by the “title” tag in “custom-icons.json” because doing it manually would take too long, so it did everything automatically using the script.

I'm still not sure how the “altNames” thing works, but if there's a problem in the future, just put the right name there if it's not recognized as it is.

imagem

I did it like this: 1- Names image per line imagem 2- Original Code imagem 3- Modify Code imagem

tur1ngb0x commented 1 month ago

The issue is the "Account Issuer" isn't "Amazon Web Services". aws.amazon.com has not been added as one of the "altNames".

If you set the issuer name to Amazon Web Services, then the icon should appear. I recommend someone adds "aws.amazon.com" in the list of "altNames" so that by default people will have the logo - Well at least it should work if someone did that but, altNames are currently not working as I mentioned here: #3875

TLDR: Change the issuer name to "Amazon Web Services" and it should work as expected.

Changing the issuer name to "Amazon Web Services" worked for now. The AWS icon is now visible.