search

entranceplus / craw

0 stars 0 forks source link

Return types of interface #8

Open shakdwipeea opened 6 years ago

shakdwipeea commented 6 years ago

I think a java model return would be better since I can use that directly in jvm clients.

rag594 commented 6 years ago

ok, so basically returning pojo(model) would suffice?

shakdwipeea commented 6 years ago

Yes

shakdwipeea commented 6 years ago

In the return type for getSubreddit, the com.entranceplus.craw.dto.Subreddit class contains the name as "/r/politics" instead of just "politics". Also, in getLinksFromReddit, the expected subreddit name is "politics".

So we could format the getSubreddit to return "politics".

shakdwipeea commented 6 years ago

In the class com.entranceplus.craw.dto.SubredditLinks, apart from the url of the article. I would also need the title and thumbnail. How difficult is to get that in ?

Note that, I am using getLinksFromReddit for this.

rag594 commented 6 years ago

In the return type for getSubreddit, the com.entranceplus.craw.dto.Subreddit class contains the name as "/r/politics" instead of just "politics". Also, in getLinksFromReddit, the expected subreddit name is "politics".

So we could format the getSubreddit to return "politics".

Fixed as a part of 73c372d58b066f2eb32c930e17159890ad3fd4a4

rag594 commented 6 years ago

In the class com.entranceplus.craw.dto.SubredditLinks, apart from the url of the article. I would also need the title and thumbnail. How difficult is to get that in ?

Note that, I am using getLinksFromReddit for this.

This is added as a part of 12172425acec5b343a6d9c862291959b4e3d5ff8