search

entropyxyz / entropy-core

Protocol and cryptography development.
https://docs.entropy.xyz/
GNU Affero General Public License v3.0
11 stars 2 forks source link

Fix how pre-generated keyshares are added for tests #1061

Closed ameba23 closed 1 month ago

ameba23 commented 2 months ago

https://github.com/entropyxyz/entropy-core/pull/1053 introduced random selection of initial signing set on jumpstart, but our pre-generated keyshares were always being added to alice, bob and charlies kvdbs, regardless of whether they were selected as initial signers.

This fixes that - the pre-generated keyshares are given to whoever is initially selected to be a signer.

ameba23 commented 2 months ago

Converting to draft as two tests are failing locally (And CI is stuck: https://github.com/entropyxyz/devops-infrastructure/issues/66 )

ameba23 commented 2 months ago

I am a little bit stuck on getting the reshare test to pass.

There are some issues with the block number having 1 subtracted from it which were not made clear before, because the OcwMessage which actually got passed from the chain was not needed since alice was no longer a signer, and the other OcwMessages which were mocked worked correctly. Now we do need alice to participate in the reshare, and things are not working.