search

entropyxyz / entropy-core

Protocol and cryptography development.
https://docs.entropy.xyz/
GNU Affero General Public License v3.0
11 stars 2 forks source link

Refactor reshare #994

Closed JesseAbram closed 3 months ago

JesseAbram commented 3 months ago

Related #941

Refactors reshare to share code between proactive refresh and reshare, mainly by pulling key reshare inputs out to a hire level and passed through

JesseAbram commented 3 months ago

So tbh I don't really understand the advantages gained by these changes. Maybe you can elaborate what problem this is solving for you?

Otherwise I'll defer to Peg here since he's more familiar with the protocol loop.

ya for sure so proactive refresh and reshare are kinda the same code in the execution step, but they take different inputs, in reshare we have n - 1 nodes with keyshares and 1 new joiner, in reshare it is n nodes, originally the input generation happened lower down in the stack so all the code up to that point needed to be duplicated, by moving it up the stack a lot of code can now be shared, that said probably gonna remove reshare eventually but who knows