Slider Links will not open.

cherrykoda commented 3 years ago

Clicking on any slider, with default slider settings across the board, will not open the link attached to the slide.

The only console output is a warning (attached):

cherrykoda commented 3 years ago

We've stripped out EVERY piece of JS and CSS from the site leaving only the slider's assets that are loaded with the plugin. The links don't work.

As soon as jQuery was removed, preventing any jQuery from functioning, the links worked. We believe this indicates an issue in the plugin's JS. Possibly a prevent default gone rogue on clicks.

Our client paid for the plugin and is not happy.

cherrykoda commented 3 years ago

Chrome Latest Release, Windows 10

andrelopez commented 3 years ago

@cherrykoda We just released Enupal Slider v1.4.0 with a fix to this issue. Please update the plugin and let us know how it goes.

cherrykoda commented 3 years ago

@andrelopez on a fresh install with version 1.4

Yes, the links are clickable. But before we get to that point:

Double Clicking the Slide to edit its information generates a server error. We were able to fix this by editing the slide's redactor config as per this logged issue: https://github.com/enupal/slider/issues/8 (The fix someone posted there works, but needs to be implemented into your codebase)

Asset Volumes. When installed the default file system path is wrong, and has to be edited manually. It should be based on Craft 3's @webroot relative paths instead of system pathing. @webroot/assets or @webroot/uploads or @webroot/public etc...
Renaming the Slider breaks the slider - gets this error on save. Reloading the page returns user to the listing screen.

Renaming the slider causes the assets to disappear for that slider, the slider does not create new folder OR move the existing folder/rename existing folder.

The most critical issue:

On deployments, Craft's Project config implements the fields, plugin data, etc. but then the plugin install does the same causing duplicate fields, field handles, asset volumes, etc. When removing the duplicates, the database breaks and the entire site goes down. The only way to resolve has been to 'restore project config' from database. The only way to avoid it is to have the craft site set to not utilize the project config feature. This is site breaking, and not fixable or workaroundable on our end.

Really sorry to tack all of this on the linking issue - but its received no attention on the other issue logs and I have your attention here. Without that project config issue fixed at a minimum this plugin is unusable.

andrelopez commented 3 years ago

@cherrykoda thanks for reporting. Let's keep track of these errors on the following tickets:

Adds support to Craft 3.5 (project config) https://github.com/enupal/slider/issues/10
Remove/Rename slider issues -> https://github.com/enupal/slider/issues/7

cherrykoda commented 3 years ago

Great, thank you!

enupal / slider

Slider Links will not open. #11