Masks implementation concerns - Githubissues

environmental-forecasting / preprocess-toolbox

A toolbox for processing downloaded datasets according to common approaches for environmental data

MIT License

0 stars 1 forks source link

Masks implementation concerns #2

Open JimCircadian opened 1 year ago

JimCircadian commented 1 year ago

Downloading specific types of masks is perhaps erroneous within this library, or they can be generated based on data types. Need to evaluate this as they don't just apply to SIC and the interface to facilitate integration with downstream pipelines needs to be clear (and the functionality split appropriately, e.g. with icenet as an example)

[x] Remove all masking from the downloaders as it stands
[x] Consider provision of mask(s) to be applied from the CLI as for use post reprojection
[ ] Document how masking should work downstream

JimCircadian commented 4 months ago

Masks are implemented by the application in question, with a default command providing a mechanism by which to incorporate them into loader configurations.