eonpatapon / gnome-shell-extension-transmission-daemon

gnome-shell indicator for transmission-daemon
40 stars 23 forks source link

Add confirmation when removing a torrent #10

Closed l300lvl closed 12 years ago

l300lvl commented 12 years ago

I wasn't sure at all what would happen when clicking the trash icon but I was hopeful there would be a confirmation of some kind. If a confirmation seems like too much perhaps a better icon would make sense, but I can't think of one off the top of my head.

I don't want to open multiple issues for these feature requests:

I also was wondering if it's at all possible to also add the ability to set the "Alternative Speed Limits". That would be a well rounded feature and really top things off.

One last thing I could think of: Add an option to display the remaining disk space for whatever Downloads is set to. I can only think it would be easiest to add this to the bottom of the menu.

Otherwise amazing work, I always look forward to your expertise. Thanks!

eonpatapon commented 12 years ago

I'm open for a better icon if you find some. As for the confirmation I'm not for it right. Seems a lot of work...

About "Alternative Speed Limits", you mean "Temporary Speed limit" ?

Last one: I don't think transmission RPC interface provides such information

l300lvl commented 12 years ago

On Tue, 2012-09-04 at 06:11 -0700, Jean-Philippe Braun wrote:

I'm open for a better icon if you find some. As for the confirmation I'm not for it right. Seems a lot of work...

About "Alternative Speed Limits", you mean "Temporary Speed limit" ?

Last one: I don't think transmission RPC interface provides such information

— Reply to this email directly or view it on GitHub.

I'm still thinking about the icon too. And the confirmation I understand, but I guess it isn't so bad since it doesn't delete the file. But what if I accidentally click remove on something that I still want to be seeding?

As for Alternative speed limit, if you open transmission>Edit>Preferences>Speed>Alternative this lets you set a speed that will over-ride the global speeds for all torrent. I guess could be considered 'temporary'. To actually set the speed you click the little turtle icon at the bottom, and this also works in the web interface.

About the remaining disk space, no transmission does not provide that, but since I assume you're connecting to the web interface it would not be hard. The web interface lets you choose the downloads folder, so there should be some way to grab that folder and than check for space remaining.

l300lvl commented 12 years ago

If you could find a way to grab the downloads folder or even a way to change the downloads folder via your extension since rpc lets you set/change it, then you could grab that and there has to be a command to output the remaining space of a folders partition right?

eonpatapon commented 12 years ago

Yes, when using the transmission-gtk client, I guess, because the folder is local.

Btw, I'm not going to implement every aspect of the rpc spec because this extension is not meant to be a client by itself, that's why you have a button for quickly accessing the web interface/gtk client to do more advanced stuff.

l300lvl commented 12 years ago

Understood. But along with the confirmation when removing a torrent, it would be a very useful addition. I understand if you don't want things to be bloated, but perhaps you will consider it for the future. It would be a lot easier than opening the gtk or web client since your extension already circumvents things like the new torrent dialog, it should also provide it's own dialogs of some kind to solve this.

Regardless, I guess the matter is resolved as a wont-fix. Excellent extension though, this doesn't mean I won't be enjoying using it!

eonpatapon commented 12 years ago

Actually I don't consider the confirmation dialog very important, since you won't click the button by mistake (it is small) and it won't delete any data...

Btw, I think I'll add a button for enabling/disabling turtle mode, this could be nice to have instead of using the pause all button. The turtle mode speeds can be configured in the client though.