ephios-dev / ephios

ephios is a django web application for managing participation for services at events, like paramedics at a festival, lifeguards at the beach, referees and judges at competitions, etc.
https://ephios.de
MIT License
26 stars 8 forks source link

Fix teams structure fullness display #1388

Closed felixrindt closed 1 month ago

felixrindt commented 1 month ago

Fixes #1381. Fixes #1382.

This is just a quick fix. We're unhappy with the inconsistencies in the assignment, fullness-determination and counts between the signup structures and therefore plan to follow up with a design session (considering all possible combinations and scenarios and what behavior we expect of them), a rewrite of much of the logic touched here and user documentation.

(There is for example another bug affecting the "full"-state for atomic blocks in the complex structure, which can't be fixed without a more thoughtful rewrite of the matching algorithms.)

@lukasrad02 feel free to test this. As we discussed in our call, this should fix the issues you're currently having with your events.

coveralls commented 1 month ago

Coverage Status

coverage: 85.283% (-0.04%) from 85.323% when pulling df80fb6923f9c3bed362d51380107a0dac2acd1a on fix-teams-fullness-display into d7192925ad042974fb62ac943f29add1b3d57994 on main.

lukasrad02 commented 1 month ago

I've noticed that there is still an inconsistency in the displayed number of missing people. Is that intended?

Screenshot from 2024-10-22 13-04-31

Scenario: