Download link has been modified

Philmore971 commented 4 years ago

The update of the addons was no longer successful. The download link has been modified. La mise à jour des addons n'aboutit plus. Le lien de téléchargement a été modifié.

Ironlenny commented 4 years ago

I don't think the url has changed. I can past the url into my browser and it works fine. If I try to just update the catolog using "https://www.curseforge.com/wow/addons?page=1", lcurse reports a 403. I get a 403 if I try curl https://www.curseforge.com/wow/addons?page=1

<!DOCTYPE html>
<!--[if lt IE 7]> <html class="no-js ie6 oldie" lang="en-US"> <![endif]-->
<!--[if IE 7]>    <html class="no-js ie7 oldie" lang="en-US"> <![endif]-->
<!--[if IE 8]>    <html class="no-js ie8 oldie" lang="en-US"> <![endif]-->
<!--[if gt IE 8]><!--> <html class="no-js" lang="en-US"> <!--<![endif]-->
<head>
<title>Access denied | www.curseforge.com used Cloudflare to restrict access</title>
<meta charset="UTF-8" />
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8" />
<meta http-equiv="X-UA-Compatible" content="IE=Edge,chrome=1" />
<meta name="robots" content="noindex, nofollow" />
<meta name="viewport" content="width=device-width,initial-scale=1,maximum-scale=1" />
<link rel="stylesheet" id="cf_styles-css" href="/cdn-cgi/styles/cf.errors.css" type="text/css" media="screen,projection" />
<!--[if lt IE 9]><link rel="stylesheet" id='cf_styles-ie-css' href="/cdn-cgi/styles/cf.errors.ie.css" type="text/css" media="screen,projection" /><![endif]-->
<style type="text/css">body{margin:0;padding:0}</style>

<!--[if gte IE 10]><!--><script type="text/javascript" src="/cdn-cgi/scripts/zepto.min.js"></script><!--<![endif]-->
<!--[if gte IE 10]><!--><script type="text/javascript" src="/cdn-cgi/scripts/cf.common.js"></script><!--<![endif]-->

</head>
<body>
  <div id="cf-wrapper">
    <div class="cf-alert cf-alert-error cf-cookie-error" id="cookie-alert" data-translate="enable_cookies">Please enable cookies.</div>
    <div id="cf-error-details" class="cf-error-details-wrapper">
      <div class="cf-wrapper cf-header cf-error-overview">
        <h1>
          <span class="cf-error-type" data-translate="error">Error</span>
          <span class="cf-error-code">1020</span>
          <small class="heading-ray-id">Ray ID: 51d71b69de948cfd &bull; 2019-09-28 16:31:20 UTC</small>
        </h1>
        <h2 class="cf-subheadline">Access denied</h2>
      </div><!-- /.header -->

      <section></section><!-- spacer -->

      <div class="cf-section cf-wrapper">
        <div class="cf-columns two">
          <div class="cf-column">
            <h2 data-translate="what_happened">What happened?</h2>
            <p>This website is using a security service to protect itself from online attacks.</p>
          </div>

        </div>
      </div><!-- /.section -->

      <div class="cf-error-footer cf-wrapper">
  <p>
    <span class="cf-footer-item">Cloudflare Ray ID: <strong>51d71b69de948cfd</strong></span>
    <span class="cf-footer-separator">&bull;</span>
    <span class="cf-footer-item"><span>Your IP</span>: 67.170.166.9</span>
    <span class="cf-footer-separator">&bull;</span>
    <span class="cf-footer-item"><span>Performance &amp; security by</span> <a href="https://www.cloudflare.com/5xx-error-landing?utm_source=error_footer" id="brand_link" target="_blank">Cloudflare</a></span>

  </p>
</div><!-- /.error-footer -->

    </div><!-- /#cf-error-details -->
  </div><!-- /#cf-wrapper -->

  <script type="text/javascript">
  window._cf_translation = {};

</script>

</body>
</html>

Looks like Cloudflare is serving up a cookie that lcurse needs to accept.

Philmore971 commented 4 years ago

impossible to do a direct download -> example : Details! Damage Meter tried with https://www.curseforge.com/wow/addons/details/download https://www.curseforge.com/wow/addons/details/download/2797484

$ wget https://www.curseforge.com/wow/addons/details/download/2797484 --2019-10-02 02:25:15-- https://www.curseforge.com/wow/addons/details/download/2797484 Résolution de www.curseforge.com (www.curseforge.com)… 104.19.147.132, 104.19.146.132, 2606:4700::6813:9284, ... Connexion à www.curseforge.com (www.curseforge.com)|104.19.147.132|:443… connecté. requête HTTP transmise, en attente de la réponse… 403 Forbidden 2019-10-02 02:25:16 erreur 403 : Forbidden.

even forcing on firefox 6 in case this is necessary, to change the Wget User-Agent of Wget, emulate a different browser

$ wget --user-agent="Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0" https://www.curseforge.com/wow/addons/details/download/2797484 --2019-10-02 02:30:56-- https://www.curseforge.com/wow/addons/details/download/2797484 Résolution de www.curseforge.com (www.curseforge.com)… 104.19.147.132, 104.19.146.132, 2606:4700::6813:9284, ... Connexion à www.curseforge.com (www.curseforge.com)|104.19.147.132|:443… connecté. requête HTTP transmise, en attente de la réponse… 403 Forbidden 2019-10-02 02:30:57 erreur 403 : Forbidden.

mboquien commented 4 years ago

FWIW, I have forked the fork of @timwienk and switched to using cloudflare-scrape (and fixed another unrelated bug that prevented updates to happen). No guarantee but it seems to be working for me. https://github.com/mboquien/lcurse

timwienk commented 4 years ago

@mboquien cool, I did the same thing, but didn't get around to testing it completely yet. good to hear that works.

timwienk commented 4 years ago

@mboquien I've added your changes to PR #80 (with a few small changes on top).

Philmore971 commented 4 years ago

Dear @mboquien, works perfectly for me ... However, I manually installed cfscrape on pipenv. I must now go over my French version completely.

timwienk commented 4 years ago

@Philmore971, does #83 help?

Other than that, I think this issue is solved (and can be closed).

ephraim / lcurse

Download link has been modified #81