search

epics-base / pvaClientCPP

pvaClientCPP is an EPICS V4 C++ module
http://epics-pvdata.sourceforge.net/index.html
Other
2 stars 8 forks source link

another attempt to fix issue 31 #32

Closed mrkraimer closed 8 years ago

anjohnson commented 8 years ago

Marty,

You removed the epicsShareClass keywords from the wrong lines; the warning messages that I posted in #31 tell you exactly which lines of the pvaClient.h file needed to be modified, lines 1351 and 1484. Please put back the epicsShareClass keywords that you just removed from lines 204, 1375 and 1517; they will probably be needed for the Windows DLL builds.

The other changes that I'm asking you to make are also in the pvaClient.h file, to add the keyword 'virtual' to the destructor declarations of the the two classes PvaClientMonitor and PvaClientRPC near lines 1360 and 1493 respectively.

Thanks,

mrkraimer commented 8 years ago

On 07/19/2016 01:46 PM, Andrew Johnson wrote:

Marty,

You removed the |epicsShareClass| keywords from the wrong lines; the warning messages that I posted in #31 https://github.com/epics-base/pvaClientCPP/issues/31 tell you exactly which lines of the pvaClient.h file needed to be modified, lines 1351 and 1484. Please put back the |epicsShareClass| keywords that you just removed from lines 204, 1375 and 1517; they will probably be needed for the Windows DLL builds.

But there are three optional requester callbacks.

PvaClientChannelStateChangeRequester PvaClientChannelStateChangeRequester PvaClientRPCRequester

All are optional and pvaCleintCPP does not have a complete implementation of any of the three. So why

The other changes that I'm asking you to make are also in the pvaClient.h file, to add the keyword 'virtual' to the destructor declarations of the the two classes |PvaClientMonitor| and |PvaClientRPC| near lines 1360 and 1493 respectively.

But neither of these is meant to be extended so why make the destructor virtual? Note that none of PvaClientGetm PvaClientPut, etc have a virtual destructor. Marty

Thanks,

  • Andrew

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/epics-base/pvaClientCPP/pull/32#issuecomment-233711316, or mute the thread https://github.com/notifications/unsubscribe-auth/AF1Q1r6tehmwlkG2NP6btJGDmizJAm0Aks5qXQ2DgaJpZM4JP-Lp.