$(SUPPORT) must be specified in RELEASE file

epics-modules / iocStats

EPICS IOC Status and Control

Other

12 stars 40 forks source link

$(SUPPORT) must be specified in RELEASE file #27

Closed kgofron closed 6 years ago

kgofron commented 6 years ago

The $(SUPPORT) must be specified in the configure/RELEASE

MarkRivers commented 6 years ago

If configure/RELEASE is going to be modified then please also see Andrew's comments under #18.

kgofron commented 6 years ago

Not defining SUPPORT in configure/RELEASE is inconsistent with other modules (asyn, calc,...) and is inconvenient if we continue using synApps scripts.

MarkRivers commented 6 years ago

I agree. What Andrew is saying is to also remove the code in the ifeq, because that does not do anything in a RELEASE file anyway.

ralphlange commented 6 years ago

@kgofron, could you please

fix the commit message of your first commit (probably needs some escape characters),
remove the ifeq clause, as that does not work in a RELEASE file to fix #18. (Consider adding "fixes #18" to your commit message for better integration.)

For the updated commit message, a force push is ok with me - no need to create another branch.

ralphlange commented 6 years ago

Sorry, never mind - there was already another PR that I just merged that had these changes.

Good news: No need to work on your branch.