For E-TC, When setting open thermocouple detect use AI_CFG_OTD_MODE r…

epics-modules / measComp

EPICS support for some USB and Ethernet I/O modules from Measurement Computing

6 stars 16 forks source link

For E-TC, When setting open thermocouple detect use AI_CFG_OTD_MODE r… #29

Closed jeonghanlee closed 1 year ago

jeonghanlee commented 1 year ago

@MarkRivers

E-TC had the same issue that TC-32 has regarding the TC Open Detection. Please check this pull request to see whether you can merge it.

Or if you have another concern, please let me know.

jeonghanlee commented 1 year ago

@MarkRivers It will make my day to hear your feedback on this request.

MarkRivers commented 1 year ago

This looks OK, I see that the uldaq driver for the E-TC does support OTD. https://github.com/mccdaq/uldaq/blob/1d8404159c0fb6d2665461b80acca5bbef5c610a/src/net/ai/AiETc.cpp#L316

Have you tested it on the E-TC and see the behavior when you set it? With OTD set unconnected channels should read -9999.

jeonghanlee commented 1 year ago

I did a quick test on one channel on E-TC unit for before and after.


B46-182:E-TC1:Ti1              25.4293
B46-182:E-TC1:Ti1OpenTCDetect  Enable
B46-182:E-TC1:Ti1Scale         Celsius
B46-182:E-TC1:Ti1TCType        Type K

B46-182:E-TC1:Ti1              -9999
B46-182:E-TC1:Ti1OpenTCDetect  Enable
B46-182:E-TC1:Ti1Scale         Celsius
B46-182:E-TC1:Ti1TCType        Type K

And I didn't see any message on the IOC console.

jeonghanlee commented 1 year ago

@MarkRivers, would you happen to have any update on this request?