Use broadcasting vs loop in day of week

epiforecasts / EpiNow2

Estimate Realtime Case Counts and Time-varying Epidemiological Parameters

https://epiforecasts.io/EpiNow2/dev/

Other

116 stars 33 forks source link

Use broadcasting vs loop in day of week #746

Closed seabbs closed 3 months ago

seabbs commented 3 months ago

Description

This PR is unrelated to an issue. It switches to using broadcasting vs a loop in the day of the week module.

Initial submission checklist

[ ] My PR is based on a package issue and I have explicitly linked it.
[x] I have tested my changes locally (using devtools::test() and devtools::check()).
[x] I have added or updated unit tests where necessary.
[x] I have updated the documentation if required and rebuilt docs if yes (using devtools::document()).
[x] I have followed the established coding standards (and checked using lintr::lint_package()).
[x] I have added a news item linked to this PR.

After the initial Pull Request

[x] I have reviewed Checks for this PR and addressed any issues as far as I am able.

github-actions[bot] commented 3 months ago

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 977a5ac1f3dd56e60bfb2f8838656de02e017eb9 is merged into main:

:heavy_check_mark:default: 42.9s -> 44.2s [-13.31%, +19.18%]
:heavy_check_mark:no_delays: 53.1s -> 49.1s [-28.88%, +14.02%]
:heavy_check_mark:random_walk: 10.7s -> 9.6s [-27.18%, +6.49%]
:heavy_check_mark:stationary: 20.6s -> 20.8s [-7.12%, +9.02%]
:heavy_check_mark:uncertain: 1.04m -> 1.06m [-19.93%, +23.17%] Further explanation regarding interpretation and methodology can be found in the documentation.

github-actions[bot] commented 3 months ago

This is how benchmark results would change (along with a 95% confidence interval in relative change) if ee563b45906002c0494be02281506fa1251d6997 is merged into main:

:heavy_check_mark:default: 43.4s -> 44.5s [-16.88%, +21.58%]
:rocket:no_delays: 54.8s -> 47s [-25.02%, -3.29%]
:heavy_check_mark:random_walk: 9.87s -> 9.85s [-8.01%, +7.5%]
:heavy_check_mark:stationary: 21.5s -> 20.4s [-18.91%, +8.72%]
:heavy_check_mark:uncertain: 1.26m -> 1.19m [-24.23%, +13.31%] Further explanation regarding interpretation and methodology can be found in the documentation.

github-actions[bot] commented 3 months ago

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 71a4daafa2960bb86377118f8a3266c3bead7556 is merged into main:

:rocket:default: 49.3s -> 38.9s [-35.04%, -6.91%]
:heavy_check_mark:no_delays: 52.3s -> 49.9s [-23.7%, +14.4%]
:heavy_check_mark:random_walk: 11s -> 9.31s [-34.44%, +3.28%]
:heavy_check_mark:stationary: 1.83m -> 19.3s [-267.96%, +102.95%]
:heavy_check_mark:uncertain: 1.11m -> 1.17m [-6.85%, +17.54%] Further explanation regarding interpretation and methodology can be found in the documentation.

github-actions[bot] commented 3 months ago

This is how benchmark results would change (along with a 95% confidence interval in relative change) if dbc0eb833b3c9e9f9f3d4dae26b932c297f9ef76 is merged into main:

:heavy_check_mark:default: 47.1s -> 44.8s [-30.97%, +21.28%]
:heavy_check_mark:no_delays: 49.3s -> 48.3s [-10.35%, +6.46%]
:heavy_check_mark:random_walk: 10.3s -> 10.1s [-7.25%, +4.18%]
:heavy_check_mark:stationary: 22.1s -> 19.8s [-21.08%, +0.38%]
:heavy_check_mark:uncertain: 1.17m -> 1.09m [-30.29%, +17.5%] Further explanation regarding interpretation and methodology can be found in the documentation.