search

epiforecasts / EpiNow2

Estimate Realtime Case Counts and Time-varying Epidemiological Parameters
https://epiforecasts.io/EpiNow2/dev/
Other
116 stars 33 forks source link

Error if first element of a `NonParametric` generation interval PMF is non-zero #806

Closed sbfnk closed 2 months ago

sbfnk commented 2 months ago 
          If `NonParametric` generation interval PMFs are going to be zero-indexed, I suggest erroring whenever there is non-zero mass in the 0 bin. I think this will cause the fewest (and the least costly) surprises for users.

Originally posted by @dylanhmorris in https://github.com/epiforecasts/EpiNow2/issues/799#issuecomment-2383838793

sbfnk commented 2 months ago

But if users might want this they could just set the first element to zero?

If what you mean is to go through a deprecation cycle for this I agree.

seabbs commented 2 months ago

I changed my mind but yes agree on a depreciation cycle