search

epiverse-trace / cleanepi

R package to clean and standardize epidemiological data
https://epiverse-trace.github.io/cleanepi/
Other
8 stars 3 forks source link

Try rendering report directly, without withr #165

Closed Bisaloo closed 3 months ago

Bisaloo commented 4 months ago

This PR aims to understand better the requirement for withr, especially since it's presently failing CRAN checks

Bisaloo commented 4 months ago

@Karim-Mane, I cannot see any issues with this approach. Do you have more details why withr was necessary?

Bisaloo commented 3 months ago

@Karim-Mane, what is the status of https://github.com/epiverse-trace/cleanepi/pull/166 please? Did you find something that would block this PR?

Karim-Mane commented 3 months ago

@Karim-Mane, I cannot see any issues with this approach. Do you have more details why withr was necessary?

print_report() was previously written in a way that the output HTML file is written in the user's current working directory by default (output_directory = "."). This was spotted, by @chartgerink, as a potential rejection factor during CRAN submission. The suggestion was to use {withr} to handle it.

Karim-Mane commented 3 months ago

@Karim-Mane, what is the status of #166 please? Did you find something that would block this PR?

I am still trying to reproduce the error I was getting. There is no reason why this cannot be merged to the main branch so far.

If I am find anything from #166, I will raise it on that PR.