epoupon / lms

Lightweight Music Server. Access your self-hosted music using a web interface.
http://lms-demo.poupon.dev
GNU General Public License v3.0
1.13k stars 62 forks source link

Multiple Artist scrobbling to Listenbrainz #513

Closed yashaskm11 closed 2 months ago

yashaskm11 commented 2 months ago

Currently only the first artist is being scrobbled to Listenbrainz, ability to include the other artists would be great.

epoupon commented 2 months ago

All the track artists are already all sent using artist_mbids

According to https://listenbrainz.readthedocs.io/en/latest/users/json.html#payload-json-details :

artist_name and track_name elements must be simple strings.

So artist_name only contains the "artist display name", that is basically what lms found in the "artist" tag. For example "XXX feat. YYY". This seems to be enough to be displayed correctly on listenbrainz. Example: image Here all three track artists are correctly parsed and are clickable.

yashaskm11 commented 2 months ago

It works perfectly for tracks with MB metadata, but tracks without MB metadata just get the first artist. Also third party implementations of ListenBrainz API like Maloja just display the first artist irrespective of MB metadata being present. Is this the expected behavior? Could there be any changes to accommodate the above scenarios?

epoupon commented 2 months ago

Since the artist_name of the LB API is a single string, lms puts the content of the artist tag, which is expected to have all the artists in a single value. Maybe that's not the case of your tracks?

yashaskm11 commented 2 months ago

I have multi valued artist tag (more than one artist tag) for my tracks. Is it possible to add all those artists with a seperator ( , and/or &) ?

epoupon commented 2 months ago

So you have only artist set, and nothing in artists?

epoupon commented 2 months ago

Could you test with epoupon/lm:bf125817 ? You need to force rescan for changes to be taken into account though

yashaskm11 commented 2 months ago

Working as expected, thanks a lot.

epoupon commented 2 months ago

Thanks for testing!