does not work with sls offline (without start)

epsagon / serverless-package-external

Add external folders to the deploy package 📦

https://epsagon.com/blog/how-to-package-external-code-in-aws-lambda-using-serverless-framework/

MIT License

55 stars 5 forks source link

does not work with sls offline (without start) #30

Closed ciekawy closed 3 years ago

ciekawy commented 3 years ago

some plugins like serverless-s3-local , serverless-dynamodb-local follow different lifecycle and they do stop for offline:start:end - the only way to use them is to do sls offline without start param. Also start triggers daemon mode while no start runs offline in pending mode waiting for Ctrl-C which is useful in some cases

to make this great plugin working also without start param there should be added

"before:offline:start": this.beforeDeploy.bind(this)

ciekawy commented 3 years ago

any chances to get it merged?

ghost commented 3 years ago

This would be great if we could get it merged. I am having the same issues.

ciekawy commented 3 years ago

@C-reddd temporarily I'm using patch-package (with just the single line mentioned above).

ghost commented 3 years ago

@ciekawy Thanks for the reply. However, I am not sure I am following 100%. How have you fixed this? I am not sure what patch-package is. Sorry for the confusion

ranrib commented 3 years ago

Thanks! 💯