Closed mphuff closed 11 years ago
ept
commented
11 years ago This is great, thanks very much Micah! I've merged it. I just found one bug: default values other than numbers or strings weren't getting rendered properly (falsy values like null and false were getting rendered as N/A, and map default values like {} were getting rendered as [object Object]). I've fixed that, and released version 0.2.0 to npm.
mphuff
commented
11 years ago Martin--
Good find on other default values.
Thank you for your help on this project! We're going to be using it EXTENSIVELY internally here at Inome :)
Micah
On Tue, Jan 22, 2013 at 12:57 PM, Martin Kleppmann <notifications@github.com
wrote:
This is great, thanks very much Micah! I've merged it. I just found one bug: default values other than numbers or strings weren't getting rendered properly (falsy values like null and false were getting rendered as N/A, and map default values like {} were getting rendered as [object Object]). I've fixed that, and released version 0.2.0 to npm.
— Reply to this email directly or view it on GitHubhttps://github.com/ept/avrodoc/pull/7#issuecomment-12565960.
The work necessary to complete issue #6 is attached.
The only thing that I know you may want to change is my use of the label on the parent protocol page (see generated output for updated example_with_messages.avsc file). I did not include the label inside of the tag as I am not a big CSS guru who was able to figure out how to get the to be styled like it is in the nav panel on the left.
I also modified the example schema to include use of an enumeration.
Let me know if you have any questions on what I did to get all of this up to date!