search

ept / avrodoc

Documentation tool for Avro schemas
Apache License 2.0
148 stars 82 forks source link

Feature/incorporate optimist commandline options #8

Closed mphuff closed 11 years ago

mphuff commented 11 years ago

I've gone ahead and done the work to incorporate the optimist js library in to avrodoc to support the following command line input options:

avrodoc input1.avsc input2.avsc --output=/tmp/newFile.html avrodoc input1.avsc input2.avsc -o=/tmp/newFile.html avrodoc input1.avsc input2.avsc --output /tmp/newFile.html avrodoc input1.avsc input2.avsc -o /tmp/newFile.html avrodoc -o /tmp/newFile.html -- input1.avsc input2.avsc avrodoc --output /tmp/newFile.html -- input1.avsc input2.avsc avrodoc --output /tmp/newFile.html -- -input1-with-hyphen.avsc

Please let me know when you've incorporated these changes as well as updated the npm website so we can pull a fresh copy down from there.

Resolves Issue #4

Thank you!

Micah

ept commented 11 years ago

Awesome, thank you Micah! I've merged it and published a new release to npm.

Just one request for next time, could you please run npm test before committing? We don't have automated tests yet, but it runs our JavaScript through jshint to keep everything in a consistent style, and to catch bugs (e.g. accidental globals due to missing var).

Thanks :)

mphuff commented 11 years ago

I can certainly do that.

Thank you for all of your help. We're very excited to start using this internally here at inome. Pretty soon here, we'll likely be generating avrodocs 50-100 times / day :)

Micah

On Wed, Jan 30, 2013 at 12:26 PM, Martin Kleppmann <notifications@github.com

wrote:

Awesome, thank you Micah! I've merged it and published a new release to npm.

Just one request for next time, could you please run npm test before committing? We don't have automated tests yet, but it runs our JavaScript through jshint to keep everything in a consistent style, and to catch bugs (e.g. accidental globals due to missing var).

Thanks :)

— Reply to this email directly or view it on GitHubhttps://github.com/ept/avrodoc/pull/8#issuecomment-12910487.