search

equinix-labs / metal-go

[Deprecated] Golang client for Equinix Metal
https://deploy.equinix.com/labs/equinix-sdk-go/
MIT License
3 stars 2 forks source link

Invitations Create API misplaced at Organizations API service #118

Closed codinja1188 closed 5 months ago

codinja1188 commented 1 year ago

As per packngo, the InvitationApiService has a create() method, but it is available at the Organizations API service in Metal-go.

Is this move happened knowingly OR was it misplaced?

@displague @ctreatma

Plz correct me if I am wrong

displague commented 1 year ago

packngo service definitions are chosen by the packngo developer. In metal-go, the definitions are drawn from the OAS3 tags, which serve multiple purposes, including determining where the endpoint lives in documentation.

If invitations have /organization in the URL, Organization placement seems reasonable.

codinja1188 commented 1 year ago

okay, looks like missing --includes and --excludes to the API.

ctreatma commented 5 months ago

It seems like we came to the conclusion that it is reasonable for this endpoint to be where it is in the SDK, and I see that the API spec has been updated to document the parameters this endpoint accepts. Closing this issue. If there are still problems with the invitations endpoint, an issue should be created in equinix/equinix-sdk-go.