search

equinix / terraform-equinix-metal-multiarch-k8s

ARM and x86 Kubernetes Clusters and Node Pool management for Equinix Metal
https://registry.terraform.io/modules/equinix/multiarch-k8s/metal/latest
32 stars 22 forks source link

Remove provider configuration from module #104

Closed keithmattix closed 2 years ago

keithmattix commented 2 years ago

Having a provider block in a TF module prevents users from using depends_on, count, or for_each directives when calling the module

Signed-off-by: Keith Mattix II keithmattix2@gmail.com

keithmattix commented 2 years ago

cc @displague

displague commented 2 years ago

Thanks, @keithmattix. This makes sense and I've been finding more need to keep providers out of the module via Implicit Provider Inheritence.

Could you update https://github.com/equinix/terraform-metal-multiarch-k8s/blob/main/examples with the coordinating change? I believe this is why the tests are failing.

keithmattix commented 2 years ago

@displague Looks like the issue was with Terraform 0.14. I bumped the CI version to 0.15 and the validation passes