Added argument time_unit to ensemble get_volumetric_rates

bkhegstad commented 1 year ago

Following the comment from Asgeir Nyvoll on fmu-postprocessing on Slack Asgeir Nyvoll no you are right so I encourage [@Bjørn Kåre Hegstad] to take a look at it if he wants it I can volunteer to review the PR

The code is tested on a local dataset and seems to work as expected.

The time_unit argument was already present in realization.py so no need for changes there.

codecov-commenter commented 1 year ago

Codecov Report

Merging #232 (1f243dd) into master (9eb672f) will not change coverage. The diff coverage is 100.00%.

:exclamation: Current head 1f243dd differs from pull request most recent head c227ab4. Consider uploading reports for the commit c227ab4 to get more accurate results

@@           Coverage Diff           @@
##           master     #232   +/-   ##
=======================================
  Coverage   83.31%   83.31%           
=======================================
  Files          14       14           
  Lines        3026     3026           
=======================================
  Hits         2521     2521           
  Misses        505      505

Impacted Files	Coverage Δ
src/fmu/ensemble/ensemble.py	`86.72% <100.00%> (ø)`

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

asnyv commented 1 year ago

Merged this one too as @bkhegstad lacked write access

equinor / fmu-ensemble

Added argument time_unit to ensemble get_volumetric_rates #232

Codecov Report