search

equinor / xtgeo

XTGeo Python class library for subsurface Surfaces, Cubes, Wells, Grids, Points, etc
https://xtgeo.readthedocs.io/en/latest/
GNU Lesser General Public License v3.0
110 stars 58 forks source link

ENH: improve algorithm for computing statistical attributes in cube. #1234

Closed jcrivenaes closed 2 months ago

jcrivenaes commented 3 months ago

The current slice_cube_window() (partly slow, partly buggy) is replaced with a new function attributes_from_cube_window() where some legacy (and less well designed) options are removed.

Solving #1232

codecov-commenter commented 3 months ago

Codecov Report

Attention: Patch coverage is 93.85475% with 11 lines in your changes missing coverage. Please review.

Project coverage is 81.15%. Comparing base (0375fed) to head (897e576). Report is 27 commits behind head on main.

Files with missing lines Patch % Lines
src/xtgeo/cube/_cube_window_attributes.py 94.76% 5 Missing and 4 partials :warning:
src/xtgeo/cube/cube1.py 66.66% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1234 +/- ## ========================================== + Coverage 80.02% 81.15% +1.13% ========================================== Files 98 93 -5 Lines 13680 12351 -1329 Branches 2203 1995 -208 ========================================== - Hits 10948 10024 -924 + Misses 1999 1669 -330 + Partials 733 658 -75 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jcrivenaes commented 2 months ago

Many changes, so I close this and add a fresh PR instead