Please ensure that the following criteria are met:
[x ] Title of pull request describes the changes/features
[x ] Request at least 2 reviewers
[ ] If new files are being added, the files are no larger than 100kB. Post the file sizes.
[ ] Code coverage did not decrease. If this is a bug fix, a test should cover that bug fix. If a new feature is added, a test should be made to cover that feature.
[ ] New features have appropriate documentation strings (readable by sphinx)
[x ] Contributor has read and agreed with CONTRIBUTING.md and has added themselves to CONTRIBUTORS.md
As a general rule of thumb, try to follow PEP8 guidelines.
Description
This is a first part update regarding the SWFlow app. In this PR, I have updated several things regarding the SWFlow solvers and tests. Specifically:
I modified the solvers for SWEs and Green-Naghdi to incluce multiple FCT/convex limiting iterations
Changed the way the entropy viscosity coefficients are defined
Cleaned up the solvers by removing unused functions, etc
Modified the python model files and the NonlinearSolvers.py file to include fixes for parallel runs
Modified the SWFlow tests to include the option of having unstructured meshes and some minor clean up
The planned future changes are as follows:
SWFlow update 2
Fix parallel issues. Current state of this issue is that the parallel runs are not perfect, ie the solution for np > 1 is not "exactly" the same for np = 1. The deviations at the moment are very tiny, but still there.
I will clean up the gauge capabilities to include the free surface values and velocity (not the momentum) values depending on what the user chooses. Currently, this can only be done in a "hacky" way.
Mandatory Checklist
Please ensure that the following criteria are met:
As a general rule of thumb, try to follow PEP8 guidelines.
Description
This is a first part update regarding the SWFlow app. In this PR, I have updated several things regarding the SWFlow solvers and tests. Specifically:
The planned future changes are as follows:
SWFlow update 2
Fix parallel issues. Current state of this issue is that the parallel runs are not perfect, ie the solution for np > 1 is not "exactly" the same for np = 1. The deviations at the moment are very tiny, but still there.
I will clean up the gauge capabilities to include the free surface values and velocity (not the momentum) values depending on what the user chooses. Currently, this can only be done in a "hacky" way.
SWFlow update 3